Skip to content

Conversation

@dmutoni
Copy link
Contributor

@dmutoni dmutoni commented Oct 26, 2021

Description of changes made


Sign in modal and sign up modal

Type of change


Please select the relevant options

  • New feature (non-breaking changes which add the new functionalities)
  • Bug fix (non-breaking changes which fix an issue)
  • Breaking change (fix or a feature that would cause existing feature not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?


Please describe the tests that you ran to verify your changes

  • Unit
  • Integration
  • End to end

How should this be manually tested?


Provide the steps to manually test the functionalities implemented in this PR

  • After cloning the repo, and cd [the project name]
  • Check out this branch by git checkout register
  • Run yarn add to install the project dependencies
  • Run yarn run dev for starting.
  • Check localhost:3000 in your browser.
  • Click the Login button in the top navigation bar.
  • Boom you will see a login modal.
  • If you don't have an account yet click the sign up page.
  • Have a look in your mobile emulator on the sign-in screen.
  • .....

Checklist:

  • My code follows the style guidelines of this project
  • I have ensured coding conventions for my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove the effectiveness of my work
  • new and existing tests pass locally with my changes

Screenshots

  • Login

signup

  • Sign up

loginPage

ers

Review

import TitleSsc from "../../components/Layouts/TitleSsc";

export default function LoginPage() {
const LoginPage = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this page looks broken

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir, I don't think so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct sign up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look here
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants